So you’re writing unit tests? Great! Are they any good? To borrow a term from Alistair Cockburn, do you have GUTs? Good unit tests? Or have you landed someone (future you?) with interest-accumulating technical debt in their testbase?
What do I mean by good? Good question. Hard question. Worth an answer.
Let’s start with names. Reflect what is being tested in the name. Yup, you don’t want
test3 as your naming scheme. In fact, you don’t want
test in your test names:
@Test already does that. Tell the reader what you’re testing, not that you’re testing.
Ah, no, I don’t mean name it after the method under test: Tell the reader what behaviour, property, capability, etc. is under test. If you’ve got a method
addItem, you don’t want a corresponding
addItemIsOK method. That’s a common test smell. Identify the cases of behavior, and test only one case per test case. Oh, and no, that doesn’t mean
Let me ask you, what’s the purpose of your test? To test that “it works”? That’s only half the story. The biggest challenge in code is not to determine whether “it works”, but to determine what “it works” means. You have the chance to capture that meaning, so try
As these names are long but also aren’t production code, consider using underscores to improve readability — camel case doesn’t scale — so
Addition_of_item_with_unique_key_is_retained. With JUnit 5 you can use
@DisplayNameGeneration to pretty-print as “Addition of item with unique key is retained”. You can see that naming as a proposition has a nice property: if the test passes, you have some confidence the proposition might be true; if it fails, the proposition is false.
Which is a good point. Passing tests don’t guarantee code works. But, for a unit test to be good, the meaning of failure should be clear: It should mean the code doesn’t work. Like Dijkstra said, “Program testing can be used to show the presence of bugs, but never to show their absence!”
In practice, this means a unit test shouldn’t depend on things that can’t be controlled within the test. File system? Network? Database? Asynchronous ordering? You have influence, but not control. The unit under test shouldn’t depend on things that could cause failure when the code is correct.
Also, watch out for overfitting tests. You know the ones: brittle assertions on implementation details rather than required features. You update something — spelling, a magic value, a quality outcome — and tests fail. They fail because the tests were at fault, not the production code.
Oh, and keep your eyes open for underfitting tests too. They’re vague, passing at the drop of a hat, even with code that’s wildly and obviously wrong. You successfully add your first item. Don’t just test the number of items is greater than zero. There’s only one right outcome: one item. Lots of integers are greater than zero; billions are wrong.
Speaking of outcome, you may find many tests follow a simple three-act play: arrange–act–assert, a.k.a. given–when–then. Keeping this in mind helps you focus on the story the test is trying to tell. Keeps it cohesive, suggests other tests, and helps with the name. Oh, as we’re back on names, you may find names get repetitive. Factor out the repetition. Use it to group tests into inner classes with
@Nested. So, you could nest
I hope that’s been useful. You’re off to do revisit some tests? OK, catch you later.